Repository navigation
fix(runtime): isolate V2 file operations from legacy schema - #43
Merged
Merged
Conversation
servicememeai
left a comment
There was a problem hiding this comment.
联动评审(2026-10-21):路由退出 Resource/Intent 旧控制面、V2 读取别名改为 Authority、禁用 Checkout 时跳过 Guard 探测的方向合理,未发现需要为本轮恢复旧路由的理由。现有 root URL 测试替身化了 seahub.urls,尚不能代表镜像中真实 URLconf 的最终优先级;合并三仓后请在集成节点对目录权限/共享只读别名、V2 管理入口以及 local-view/optimistic/exclusive 三种模式做一次针对性 HTTP smoke。不要为此扩展历史兼容层。
Author
|
评审跟进(2026-10-21): 已按你的意见做了静态核对,未改代码:
结论:本 PR 代码层面无新增修改,等待三仓合并后的集成 smoke。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Disabled Checkout returns before Guard discovery; enabled Checkout requires the reviewed path-keyed schema. The current root URLconf no longer mounts the historical Resource/Intent/SchemaRunner control plane. Native library/file reads remain, and effective-permission, shared-directory and directory-entry compatibility aliases now use the existing V2 views directly instead of old NativeRead.
Current V2 management and directory sync endpoints remain registered by seahub.urls. Historical directory-address, library-rules, directory-shares, directory/sync, hosted identity/editing/transfer and capabilities routes are no longer mounted by the root URLconf; their historical fields are not reintroduced into the four-table schema. The retained aliases use V2 parameters and response bodies.
Validation: 28 targeted tests and 7 subtests passed, covering root URL resolution, absence of retired routes, real V2 permission decisions, native Cookie reads and Checkout-disabled behavior. Native boundaries are doubled in this unit suite; no live HTTP/image deployment was performed. Coordinate with Server #21 and the Docker four-table runtime PR. No DDL or environment-variable changes.