Repository navigation
fix(storage): unify C/Go objects and new-library V2 routing - #17
Merged
Merged
Conversation
… libraries [skip ci]
… closed [skip ci]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope (current
devonly)cf_v2_store_dircontract, matching C Blocks. Reject corrupt/unresolved routes instead of falling back to native paths; preserve native migration/export version-0 layout.v2StorageBackendin the realnewBackendconstructor, accept both config filename and directory, and refuse incompatible legacy multiple/S3 backends when the V2 managed root is present.cf_library_storageandRepoStorageIdbefore the first commit, activate on successful creation, mark retired for cold GC. Preserve oldcf_pin_default_local_storageonly when no V2 root is configured; refuse new per-library class override in V2.Minimal checks
tests/local_storage/run.sh.cf_v2_route_wiring_test.goviago test ./objstore; optional bind-mount EXDEV regression only in a disposable mount-capable environment.devalready defaults to current Server/Hub dev and allowlists all modified native seams. Hub OAuth source isolation is a separate PR #32, not part of this storage change.Release boundary
Merge only after cheap CI and targeted source review. User authorization is required separately for native build, image publication, DEV deployment or rollback. Runtime acceptance must use a fixed Server/Hub/Docker SHA tuple and verify old native-library reads, new managed-library C/Go bytes and real upload/download.