mux: consume buffered samples without moving them - #299
Merged
Merged
Conversation
Consuming samples in readBufferAndAdd moved all the remaining buffered bytes to the front of the buffer on every audio callback. Track the consumed offset instead and compact the buffer lazily when it is refilled, i.e. once per wrap-around instead of once per callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introducing ring buffer to improve the speed.
Consuming samples in
readBufferAndAddmoved all the remaining buffered bytes to the front of the buffer on every audio callback. Track the consumed offset instead and compact the buffer lazily when it is refilled, i.e. once per wrap-around instead of once per callback.