Conversation
Owner
|
Your right it’s a duplicate, but I think I would rather remove the first one, there is no point in warning about a missing hardware type if the user specified a different one (hmm.. unless the default is used in other places) |
ecki
requested changes
Sep 24, 2026
ecki
left a comment
ecki
left a comment
Owner
There was a problem hiding this comment.
It’s a possible way, but maybe better delete the early block.
Move default hardware type initialization after getopt_long. If no -H or -t option was specified, fall back to default.
sakh-ML
force-pushed
the
remove-dead-hwtype-check
branch
from
September 24, 2026 18:59
cc16db2 to
1ae5c18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hw already gets set to the default type earlier in main() before argument parsing. This block just repeats that same check when no -H/-t option was given, so it can never actually do anything different. Removing it as dead code.