vehicle_time: Deliver VehicleClock callbacks from a worker thread - #215
Open
florianfueller wants to merge 4 commits into
Open
vehicle_time: Deliver VehicleClock callbacks from a worker thread#215florianfueller wants to merge 4 commits into
florianfueller wants to merge 4 commits into
Conversation
florianfueller
had a problem deploying
to
workflow-approval
September 8, 2026 18:24 — with
GitHub Actions
Error
florianfueller
had a problem deploying
to
workflow-approval
September 8, 2026 18:24 — with
GitHub Actions
Error
License Check Results🚀 The license check job ran with the Bazel command: bazel run //:license-checkStatus: Click to expand output |
florianfueller
force-pushed
the
feature/59-vehicle-clock-callback-delivery
branch
from
September 9, 2026 07:57
d4f4e67 to
143d1fb
Compare
florianfueller
had a problem deploying
to
workflow-approval
September 9, 2026 07:58 — with
GitHub Actions
Error
florianfueller
had a problem deploying
to
workflow-approval
September 9, 2026 07:58 — with
GitHub Actions
Error
florianfueller
force-pushed
the
feature/59-vehicle-clock-callback-delivery
branch
from
September 9, 2026 11:18
143d1fb to
d447876
Compare
florianfueller
had a problem deploying
to
workflow-approval
September 9, 2026 11:18 — with
GitHub Actions
Error
florianfueller
had a problem deploying
to
workflow-approval
September 9, 2026 11:18 — with
GitHub Actions
Error
Implement callback delivery in VehicleClockBackendImpl; the Set and Unset methods were no-ops so far. - A worker thread, started by the first successful Init(), polls the TimeDaemon shared memory every 50 ms while at least one callback is registered and dispatches on that thread. - TimeSlaveSyncData and PDelayMeasurementData fire on every changed frame. - VehicleTimeStatus fires once after registration, then only when the flags change (rate deviation excluded). - Subscribe and Unsubscribe are safe against in-flight invocations, including calls from inside a callback. - Add unit tests, update docs and comments, remove the "not yet delivered" warnings. Refs eclipse-score#59 Signed-off-by: Florian Füller <5454068+florianfueller@users.noreply.github.com>
florianfueller
force-pushed
the
feature/59-vehicle-clock-callback-delivery
branch
from
September 9, 2026 12:37
d447876 to
a816147
Compare
florianfueller
had a problem deploying
to
workflow-approval
September 9, 2026 12:38 — with
GitHub Actions
Error
florianfueller
had a problem deploying
to
workflow-approval
September 9, 2026 12:38 — with
GitHub Actions
Error
florianfueller
marked this pull request as ready for review
September 9, 2026 12:38
Move change detection into CallbackSlot: the slot remembers the key of the last delivered value and forgets it on Set/Unset, so every newly registered callback receives the next frame and afterwards only changes. This replaces the registration counter and the backend's per-event bookkeeping. - Run the callback under a recursive mutex instead of the explicit in-flight wait; the mutex now provides the Set/Unset guarantees. - Adapt unit tests and docs. Refs eclipse-score#59 Signed-off-by: Florian Füller <5454068+florianfueller@users.noreply.github.com>
florianfueller
had a problem deploying
to
workflow-approval
September 9, 2026 18:58 — with
GitHub Actions
Error
florianfueller
had a problem deploying
to
workflow-approval
September 9, 2026 18:58 — with
GitHub Actions
Error
florianfueller
requested a deployment
to
workflow-approval
September 10, 2026 13:09 — with
GitHub Actions
Waiting
florianfueller
requested a deployment
to
workflow-approval
September 10, 2026 13:09 — with
GitHub Actions
Waiting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improvement
Description
Implement callback delivery in
VehicleClockBackendImpl; theSet*/Unset*methods wereno-ops so far.
Init(), polls the TimeDaemon sharedmemory every 50 ms while at least one callback is registered and dispatches on that thread.
TimeSlaveSyncData/PDelayMeasurementDatafire on every changed frame.VehicleTimeStatusfires once after registration, then only when the flags change(rate deviation excluded).
Subscribe/Unsubscribeare safe against in-flight invocations, including calls frominside a callback.
Related ticket
closes #59 (improvement ticket)