Repository navigation
Conversation
Contributor
Author
|
Tested on ERA5, NPPATMS, SurfaceCombined with the following config: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
New design for the plotting folder to accommodate for the parallelization:
Every plot is classified by what it is drawn from:
ReaderOutput). They are drawn where the data is loaded: by each worker under MPI, by_process_streamin a serial run. A worker draws only the samples × forecast steps of its own chunk.MetricResults:.score,.spatial,.by_init_hour). Scores are averages over samples, so these plots are drawn once, after the per-chunk results are merged. That happens on the master under MPI, and at the end ofevaluate_from_configin a serial run.The master never needs the loaded data. The workers never need another chunk's results. This is the same split as scoring:
score_orchestrationcomputesMetricResults per chunk, and the master merges them.plot_utils.pyholds the common helpers;field_plots.pyandverification_plots.pyone side each, with the score maps in their ownscore_maps.pyand the videos of both sides inanimations.py;plot_orchestration.pyholds what the run loop calls.field_plots.pyplot_data(orchestration of maps and histograms: config, availability, fstep filtering, colour ranges, task building, dispatch);_plot_single_sample,_plot_histograms_across_samples,_select_ensemble_data,_dispatch_timeseries_plotsplot_orchestration.pyverification_plots.pyplot_scores(orchestration of thescore_plotsentries over metric × region); the eight driverslead_time_plot_metric_region,ratio_plot_metric_region,heat_maps_metric_region,score_card_metric_region,bar_plot_metric_region,quantile_plot_metric_region,psd_plot_metric_region,init_hour_metric_region;_flatten_or_average,_extract_psd_attrsplot_orchestration.pyscore_maps.pyplot_score_maps(orchestration of the score maps, including the per-(metric, region) colour ranges);_plot_score_maps_per_stream,_plot_score_map. Verification side: drawn from the mergedMetricResult.spatialrun_evaluation.pyfor now thenplot_orchestration.pyfrom one of the next PRsanimations.py_build_single_animation,_dispatch_field_animations,_dispatch_score_map_animationsfield_plots.py,score_maps.pyplot_utils.pyplot_orchestration.pyrun_evaluation.pyNO CODE CHANGE. Functions are moved as they are, except for the following renames:
run_score_map_pipelineplot_score_maps_scatter_plot_single_plot_score_mapPlotter.create_maps_per_sample)plot_summary+plot_init_hour_summaryplot_scoresscore_plotsentries; no "summary" namingplot_init_hour_summaryinit_hour_metric_regionplot_metric_regionlead_time_plot_metric_region_plot_all_samples_plot_histograms_across_samples_dispatch_animations_dispatch_field_animations_dispatch_score_map_animations; it builds only map and histogram videosIssue Number
Closes #2993
Is this PR a draft? Mark it as draft.
Checklist before asking for review
./scripts/actions.sh lint./scripts/actions.sh unit-test./scripts/actions.sh integration-testlaunch-slurm.py --time 60FastEvaluation