Skip to content

feat: add image secrets to DaemonSets - #191

Merged
MoisesGSalas merged 1 commit into
eduNEXT:mainfrom
open-craft:agrendalath/daemonset-image-secrets
Sep 24, 2026
Merged

MoisesGSalas merged 1 commit into
eduNEXT:mainfrom
open-craft:agrendalath/daemonset-image-secrets

Conversation

@Agrendalath

Copy link
Copy Markdown
Contributor

This is required to pull a custom codejail-aa-loader image.
Ref: https://github.com/eduNEXT/tutor-contrib-codejail/blob/98c31cc/tutorcodejail/patches/k8s-deployments#L40

Private-ref: BB-11200

@Agrendalath
Agrendalath requested a review from a team as a code owner September 21, 2026 15:06
@MoisesGSalas

MoisesGSalas commented Sep 24, 2026 •

Copy link
Copy Markdown
Member

Thanks @Agrendalath, would you mind adding a changelog entry? You can create a changelog fragment by running make changelog-entry.

I saw that you opened a few PRs in some of our repos so this comment also applies to them.

This is required to pull a custom `codejail-aa-loader` image.
@Agrendalath
Agrendalath force-pushed the agrendalath/daemonset-image-secrets branch from 5563f4d to 576a27b Compare September 24, 2026 14:38
@Agrendalath

Copy link
Copy Markdown
Contributor Author

@MoisesGSalas, sure thing - I added changelog entries to 5 PRs. I skipped 2 PRs made to picasso, as it does not have the changelog.

@MoisesGSalas
MoisesGSalas merged commit 13f53f9 into eduNEXT:main Sep 24, 2026
11 checks passed
@Agrendalath
Agrendalath deleted the agrendalath/daemonset-image-secrets branch September 24, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants