Repository navigation
feat(vue): pause command chrome while a dialog is open - #919
Merged
Merged
Conversation
Command.suspendWaiting parks on an effect without the spinner or the waiting toast. The button stays disabled until the effect finishes, then both come back for the rest of the command.
@effect-app/cli
effect-app
@effect-app/eslint-codegen-model
@effect-app/eslint-shared-config
@effect-app/infra
@effect-app/vue
@effect-app/vue-components
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A command that asks a question before the real work shows the spinner and the waiting toast while the person is still deciding. The button looks busy before anything has started.
Command.suspendWaiting(effect)pauses both for that effect. The button stays disabled, so a second click cannot start another run. When the effect finishes, the spinner returns and the waiting toast starts its one-second delay again for the rest of the command. An interrupt restores the depth and clears the toast.Each command owns a
WaitingGate.command.waitingis false while the depth is positive.command.blockedstays on for the whole run.WithToastdismisses the waiting toast above depth 0 and arms a fresh delay when the depth returns to 0. Outside a command the default gate is inactive, sosuspendWaitingruns the effect unchanged.Stream commands pause the spinner only.
withDefaultToastStreamis unchanged.confirmOrInterruptis unchanged: nativewindow.confirmblocks the thread, so that spinner does not paint.Need help on this PR? Tag
@codesmith-botwith what you need.