Repository navigation
Fix terminal command review and input recovery; release 0.8.8 - #67
Merged
Merged
Conversation
Release 0.8.8 with verified PTY I/O outcomes, restoration generation guards, and real shell/editor regressions. Keep native Mac acceptance limits explicit.
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wrapped command editing could let a cursor-row suffix determine approval for the entire command. Cancelling a review in the middle of a line could also leave a suffix that received the next agent command. This patch preserves complete tracked commands, refuses uncertain edits, and separates cancellation from confirmed physical input cleanup.
PTY write/flush failures now report uncertain delivery without replay, resize dimensions are published only after the local PTY confirms them, and obsolete checkpoint callbacks cannot mark a new terminal attachment ready. The release is bumped to 0.8.8.
Validation: 288 Rust tests (1 existing ignored), 68 common UI tests, 10 production web/MCP scenarios, 25 local and 26 direct SSH input/rendering scenarios, 20 real Vim edit/save scenarios across Linux Chromium/WebKit and local/SSH, 85 screen comparisons, 984 checkpoint cases, app lifetime checks, 81 release-tool tests, common contract/boundary checks, and both frontend builds passed. New tests verify actual file content and complete review identity, not only matching terminal grids.
The user's native macOS Vim freeze and actual gateway rendering issue remain unconfirmed on that Mac. Linux browser tests do not establish native Mac acceptance. The report distinguishes fixture locale/setup failures, observed WebKit warnings, and packaging checks from interactive behavior.
See validation and 한국어 검증.