Repository navigation
Fix AppImage shell environment and agent header overflow - #70
Merged
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for users?
Attaching several agents no longer stretches a session header until badges and the close control are clipped. The header shows a representative name and
+N; a keyboard-accessible list exposes full names and distinct connection IDs, including repeated names. The current controller becomes the representative, and the list updates when connections disconnect.AppImage terminal children no longer inherit paths to the desktop bundle's libraries and GTK resources. Host paths are preserved, and explicit engine/profile overrides still take precedence, so host commands such as Flatpak load their own libraries.
Add production UI/PTY/MCP regressions for empty Readline edits and retained human input. Make the existing Readline fixture independent of the runner's
TERM. Input protection behavior is unchanged.Closes #68. Closes #69. Refs #65.
Validation
cargo test --locked: 292 passed, no failures. The isolated environment helper is exercised by its parent; the existing SSH-lab test requires an external fixture.npm run test:ui: 68 passed.Limits or follow-up
Native verification used Ubuntu 26.04.1 x86_64, Bash/Readline and a virtual X11 display with accessibility actions and XTest keyboard input. FUSE was unavailable, so the exact built AppImage was extracted and launched through
AppRun. macOS, Wayland and fractional scaling were not tested.Issue #65 did not reproduce in the tested Ubuntu build. Retained human input still blocks agent Type/Enter with
input_pending, and empty-edit cases execute normally; this PR adds coverage without claiming a fix for unverified platform behavior.The local AppImage is an unreleased debug test build, not an installer or updater release. Its SHA256 is
7340f913ff5f853ae4a943e968860ca256b523f5d3f2da38fa55ac790a182b2f.