Skip to content

fix: say which requirement has no license when packaging stops - #79

Merged
ehennestad merged 1 commit into
ehennestad:mainfrom
stevevanhooser:fix/missing-license
Oct 26, 2026
Merged

ehennestad merged 1 commit into
ehennestad:mainfrom
stevevanhooser:fix/missing-license

Conversation

@stevevanhooser

Copy link
Copy Markdown
Contributor

packageToolbox adds each GitHub requirement to the toolbox as additional software with the URL of its license file. When GitHub finds no license for one of them, its /license endpoint returns 404 and packaging stopped with the raw webread error, which doesn't say what to do:

The server returned the status 404 with message "Not Found" in
response to the request to URL
https://api.github.com/repos/VH-Lab/pyraview/license.

getLicenseHtmlUrl now turns that 404 into a MatBox:GitHub:LicenseNotFound error naming the repository and asking for a LICENSE file. Packaging still stops, as it should: MATLAB needs a valid license URL for each additional software package, shown to the user during installation.

Not run: MATLAB is not available where this was written.

Claude-Session: https://claude.ai/code/session_01W156oKLRkXpxcrNEtFtyxH

packageToolbox adds each GitHub requirement to the toolbox as additional
software with the URL of its license file. When GitHub finds no license
for one of them, its /license endpoint returns 404 and packaging stopped
with the raw webread error, which doesn't say what to do:

  The server returned the status 404 with message "Not Found" in
  response to the request to URL
  https://api.github.com/repos/VH-Lab/pyraview/license.

getLicenseHtmlUrl now turns that 404 into a MatBox:GitHub:LicenseNotFound
error naming the repository and asking for a LICENSE file. Packaging
still stops, as it should: MATLAB needs a valid license URL for each
additional software package, shown to the user during installation.

Not run: MATLAB is not available where this was written.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01W156oKLRkXpxcrNEtFtyxH

@ehennestad ehennestad left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehennestad
ehennestad enabled auto-merge (squash) October 26, 2026 19:41
@ehennestad
ehennestad merged commit 2166404 into ehennestad:main Oct 26, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants