Skip to content

(withdrawn) - #22384

Closed
robertziel wants to merge 1 commit into
elastic:mainfrom
robertziel:compose-env-config
Closed

robertziel wants to merge 1 commit into
elastic:mainfrom
robertziel:compose-env-config

Conversation

@robertziel

@robertziel robertziel commented Nov 5, 2026 •

Copy link
Copy Markdown

Opened by mistake, withdrawn.

…edentials from .env

Every deployment-specific value in docker-compose.yml now comes from .env
(documented in .env.example) and is required: docker compose fails with
'set <VAR> in .env' instead of silently using a default.

- STACK_BIND_IP, ES_PORT, KIBANA_PORT: host bind address and ports
- ES_HEAP, ES_LOG_LEVEL
- KIBANA_ES_USER/PASS; METRICBEAT_ES_USER/PASS (previously Metricbeat
  reused KIBANA_ES_USER with a different default)
- make system-test loads .env so the tests use the same ports
- CI and testing/stack-monitoring.sh create/load .env
@robertziel
robertziel requested review from a team as code owners November 5, 2026 17:17
Copilot AI balanced review requested due to automatic review settings November 5, 2026 17:17
@cla-checker-service

Copy link
Copy Markdown

❌ Author of the following commits did not sign a Contributor Agreement:
80b79a9

Please, read and sign the above mentioned agreement if you want to contribute to this project

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify

mergify Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

This pull request does not have a backport label. Could you fix it @robertziel? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8.19 is the label to automatically backport to the 8.19 branch.
  • backport-9./d is the label to automatically backport to the 9./d branch. /d is the digit.
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@robertziel robertziel closed this Nov 5, 2026
@robertziel
robertziel deleted the compose-env-config branch November 5, 2026 17:20
@robertziel robertziel changed the title docker-compose: read bind address, ports, heap, log level and credentials from .env (withdrawn) Nov 5, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The .env loaders reject valid Compose syntax and overwrite exported overrides, causing port mismatches, test failures, or aborted monitoring setup.

2 open issues
What changed in this PR

Moves deployment-specific Docker Compose settings into required environment variables, with a documented .env.example, while keeping image tags literal for existing tooling.

Changes:

  • Makes bind address, ports, heap size, log level, and service credentials configurable.
  • Loads .env in system-test and monitoring entry points, and creates it in CI.
  • Documents setup and excludes the local .env from version control.
File Description
testing/​stack-monitoring.sh Loads .env and uses the configured Kibana port.
Makefile Requires and loads .env for system tests.
docker-compose.yml Replaces hardcoded settings and defaults with required variables.
dev_docs/​TESTING.md Documents environment setup and system-test commands.
.gitignore Ignores the root .env file.
.github/​workflows/​ci.yml Copies example settings before starting CI stacks.
.env.example Documents required settings and provides starter values.

Review effort: Balanced

Comment thread Makefile
# CGO is disabled when building APM Server binary, so the race detector in this case
# would only work on the parts that don't involve APM Server binary.
@(cd systemtest; go test $(GOMODFLAG) $(GOTESTFLAGS) -tags=$(DEFAULT_TAGS),$(GOTAGS) -race -timeout=20m ./...)
@(set -a && . ./.env && set +a && cd systemtest && go test $(GOMODFLAG) $(GOTESTFLAGS) -tags=$(DEFAULT_TAGS),$(GOTAGS) -race -timeout=20m ./...)
Comment thread Makefile
# CGO is disabled when building APM Server binary, so the race detector in this case
# would only work on the parts that don't involve APM Server binary.
@(cd systemtest; go test $(GOMODFLAG) $(GOTESTFLAGS) -tags=$(DEFAULT_TAGS),$(GOTAGS) -race -timeout=20m ./...)
@(set -a && . ./.env && set +a && cd systemtest && go test $(GOMODFLAG) $(GOTESTFLAGS) -tags=$(DEFAULT_TAGS),$(GOTAGS) -race -timeout=20m ./...)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants