Repository navigation
[9.6] (backport #22390) fix flaky test TestApprovedMetrics - #22395
Conversation
🤖 GitHub commentsJust comment with:
|
There was a problem hiding this comment.
🟢 Approval recommended
No active review issues are reported for the backport, which focuses metric approval checks on agent metrics.
No open issues 🎉
What changed in this PR
Backports #22390 to the 9.6 branch to address flaky TestApprovedMetrics results reported in #21608. The test now excludes server-aggregated metrics so approval checks focus on agent metrics.
Changes:
- Exclude metrics containing
metricset.interval, rather than only transaction metrics. - Remove a stray trailing backtick from the metricset fixture.
| File | Description |
|---|---|
testdata/intake-v2/metricsets.ndjson |
Remove a stray backtick to keep the final fixture record valid JSON. |
systemtest/metrics_test.go |
Filter out server aggregates using metricset.interval and update the explanatory comment. |
Review effort: Balanced
💚 Build Succeeded
cc @aelnahas |
|
Dependency review finished without posting an analysis comment. If you expected a review, push a new commit to this pull request (or close and reopen it) to try again. Workflow run: https://github.com/elastic/apm-server/actions/runs/42227598061 |
✅ Merged into
|
Motivation/summary
commit attempts a fix on TestApprovedMetrics by filtering out server aggregates to focus on agent metrics.
Checklist
For functional changes, consider:
How to test these changes
Related issues
fixes: #21608
This is an automatic backport of pull request #22390 done by [Mergify](https://mergify.com).