Repository navigation
MutterTestCase: Setup context in set_up - #2966
Merged
Merged
Conversation
leolost2605
marked this pull request as draft
October 31, 2026 13:10
leolost2605
marked this pull request as ready for review
October 31, 2026 13:15
danirabbit
approved these changes
Oct 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During
constructtests haven't even been inited yet. This means any warnings and errors during setup won't be picked up by the tests. Apart from that it's also just good practice to do setup only once the tests are run.For example we now get a log that
scale-monitor-framebufferis an invalid experimental feature on mutter >= 50. We could just filter that but since we won't release on OS 8 anymore anyways just drop it.We for now have to filter another log but those filters can be dropped with #2965