Repository navigation
Conversation
This was referenced Nov 1, 2026
leolost2605
requested changes
Nov 5, 2026
leolost2605
left a comment
leolost2605
left a comment
Member
There was a problem hiding this comment.
Just a few nitpicks.
I think this makes sense for the wingpanel but I'm not sure if it's needed in greeter. I think there (and elsewhere we need a password entry, e.g. polkit) it's enough to have the state up to date when it's focused. But maybe @elementary/ux has opinions here :)
garaevdi
force-pushed
the
expose-caps-and-num-lock
branch
from
November 7, 2026 12:49
5177e18 to
354ea0c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On wayland only the window with a keyboard focus can query whether those toggle keys are pressed, which resulted in a broken indication in keyboard indicator and greeter.
While we are at it, also make this class follow modern guidelines and use GObject-style construct method
Inspired by downstream NixOS patch by @amz-x https://github.com/amz-x/nixpkgs/blob/eab6fd0d94ee2510caf5e146ef319c8d4360371e/pkgs/desktops/pantheon/desktop/wingpanel/feature-lock-state-interface.patch