Repository navigation
PanelWindow: Fix gap between maximized window and wingpanel - #745
Merged
Merged
Conversation
When fractional scaling is enabled it can happen that the wingpanel covers half a pixel. This causes a visible gap to appear between a maximized window and the panel. We will be able to solve this properly in Gtk 4.24 with Gtk.Snapshot.set_snap but since that's not available even in OS 9 let's work around it. The workaround might cause the top most pixel of an app to disappear behind the panel but that shouldn't be really noticeable.
danirabbit
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When fractional scaling is enabled it can happen that the wingpanel covers half a pixel. This causes a visible gap to appear between a maximized window and the panel. We will be able to solve this properly in Gtk 4.24 with Gtk.Snapshot.set_snap (see https://blogs.gnome.org/gtk/2026/05/28/snapping/) but since that's not available even in OS 9 let's work around it.
The workaround might cause the top most pixel of an app to disappear behind the panel but that shouldn't be really noticeable.
Fixes the gap seen in the screenshot below with 1.25 scaling. You can see the white background shimmer through which is quite annoying
(I did actually test Gtk.Snapshot.set_snap by running a flatpak build of wingpanel and it did fix the issue)