fix: ci: stop check-canon failing on the 2026-05 audit record it cannot rewrite - #2
Draft
srpatcha wants to merge 1 commit into
Draft
fix: ci: stop check-canon failing on the 2026-05 audit record it cannot rewrite#2srpatcha wants to merge 1 commit into
srpatcha wants to merge 1 commit into
Conversation
…ot rewrite Opened by the scheduled autoreview pipeline after review of open PRs. Reviewed against the EmbeddedOS Master Design v2.0. Files: scripts/check-product-canon.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
check-canonhas failed on every run since 2026-05-19 and has never beengreen since. Its last success was run
25777395642
on 2026-05-13; every run after that is a failure, including the ones on
master(26149265404,26148951962,
26127809462)
and the most recent one,
32614652320.
Running
scripts/check-product-canon.pyagainstorigin/masterreports 26forbidden references. All 26 are inside
audit-2026-05/, and the greatmajority are in lines that name the deprecated repos precisely in order to ban
them:
Root cause
audit-2026-05/landed on 2026-05-19 in d5580a1 and 8c2838c — the same day thelane went red, and it has stayed red ever since. That directory is the dated
record of the rename the validator enforces: the per-repo checklists tell a
maintainer to remove the old names,
README-contract.mddefines what counts asa violation,
session1-summary.mdlogs what was done, andper-repo/eVera.mdexists because eVera was audited before it was dropped.The validator has no way to tell "this file uses the old name" from "this file
is the instruction to stop using the old name", so it flags the audit for
containing the very strings that make it an audit.
Fix
Add
audit-2026-05/toEXCLUDE_PATH_FRAGMENTSinscripts/check-product-canon.py, alongside the exclusions that already existfor exactly this reason:
Both separator spellings are listed, matching how
tests/screenshotsand theecosystem guide are already handled for Windows checkouts.
The alternative — editing the old repo names out of the 2026-05 audit — was
rejected: it would make a dated compliance record say something it did not say
in 2026-05, and
per-repo/eVera.mdcannot be corrected at all, because itssubject is a product that no longer exists.
Files changed
scripts/check-product-canon.py— seven lines added toEXCLUDE_PATH_FRAGMENTS(five of them the comment). No logic changed.Expected impact
check-canongoes green onmasterfor the first time since 2026-05-13, sothe next real canon regression is visible instead of arriving into an
already-red lane.
Risks and compatibility
excluded files are all under
audit-2026-05/. A future canon violation addedinside that directory would no longer be caught. That is the deliberate
trade, and it is the reason this is opened as a draft rather than as a
routine fix — if the intent is for the audit directory to stay under the
validator, the correct answer is to move it somewhere it is unambiguously
archival, not to keep the lane red.
eVeraplacedat the repo root is still caught and still fails the run; that is recorded
under the
canon-still-bitescheck below, with the offending path named inits output.
nothing about what the validator looks for changes — only where it looks.
lint-readmeis also red, and it is red on the same directory: itslycheejob fails on the link../../C:/Users/spatchava/.llms/plans/production_readiness_20_repo_audit.plan.md,which every
audit-2026-05/per-repo/*.mdcarries, and 369 of its 469markdownlint errors are under
audit-2026-05/as well. This PR does notaddress
lint-readme:lycheeandmarkdownlinthave their own ignoremechanisms, and 100 of those markdownlint errors are outside the audit
directory, so that lane stays red either way. It is recorded in the sweep
backlog separately.
Surfaced by the maintenance sweep scan
state/maint/20260906T013056/.github.md, §"CI — latest run on master".Verification
Executed in an isolated worktree branched from
origin/master:canon-still-bitespython3 /tmp/check_canon_still_bites.pycheck-canonpython3 scripts/check-product-canon.pyOpened by the scheduled autoreview pipeline (model
claude-opus-5), branched fromorigin/master. No human has reviewed this yet. Close it freely if the fix is wrong - a bad automated PR is a bug worth reporting.Fixes #4