Repository navigation
Conversation
CI splits the Node suite over 8 shards, each with its own server, so these only fail in a full run against a single server: - The sandbox hook-event test listed the test plugin's events with limit 100; a full run records more. The plugin's events-list route now accepts `ids` for a direct lookup. - The sandbox user-list check required exactly one user, but the passkey setup test adds a second. - In a crowded root folder the dragged media row sat at the viewport's bottom edge, where dnd-kit auto-scrolls and the drop target moves. pointerDrag now scrolls the source to the centre and re-measures the target during the drag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 27, 2026
ostenbom
marked this pull request as ready for review
October 29, 2026 23:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Three Node E2E tests fail when the whole suite runs against one server, as it does in a full local
pnpm test:e2erun. CI doesn't catch them because each of its 8 shards gets its own server and database.sandbox-plugin-admin-surfaces: the hook-events check read the first 100 events, and a full run records more. The test plugin'sevents-listroute now takesids, and the test looks up its own two events.sandbox-plugin-boundaries: it expected exactly one user, but after the passkey setup test there are two. It now checks that the dev admin is in the list.media-librarydrag into a folder: in a crowded root folder the dragged row sat at the viewport's edge, where dnd-kit auto-scrolls. The drag helper now scrolls the row to the centre and re-measures the drop target. It still fails now and then when the folder is very crowded.This is independent of the two E2E speed-up PRs (#6 and #7), but you need it for a full local run of either.
I used claude to help me create this PR, but I have run the suite and reviewed the code myself.
Type of change
Your connection to this change
Checklist
pnpm typecheckpassespnpm lintpassespnpm testpasses (or targeted tests for my change): the full Node suite on one server, with these fixes, locally against both the dev server and a production buildpnpm formathas been run@emdash-cms/plugin-marketplace-testis privateAI assistance disclosure
Screenshots / test output
Not applicable.