Preserve sticky module requirements during purge - #693
Open
adrien-cotte wants to merge 1 commit into
Open
Conversation
Purge skips sticky and super-sticky modules but still attempts to unload their non-sticky requirements. This reports an unrelated dependency error without explaining why the requirement remains loaded. Preserve requirements needed by retained sticky modules and apply the sticky_purge reporting mode to their skipped unload. Fixes envmodules#582 Assisted-by: Codex:gpt-5.6-sol Signed-off-by: Adrien Cotte <adrien.cotte@asplus.fr>
xdelaruelle
force-pushed
the
fix/sticky_prereq_purge
branch
from
September 1, 2026 05:04
a005bf0 to
2f4a98e
Compare
xdelaruelle
reviewed
Sep 1, 2026
| } | ||
|
|
||
| proc getStickyReqUnloadMsg {{tag sticky}} { | ||
| return "Unload skipped because module is required by a $tag module" |
Collaborator
There was a problem hiding this comment.
Use a shorter message structure: Unload of $tag module requirement skipped
xdelaruelle
requested changes
Sep 1, 2026
xdelaruelle
left a comment
xdelaruelle
left a comment
Collaborator
There was a problem hiding this comment.
Testsuite should be fixed as CI jobs are failing.
Documentation should be adapted to mention this behavior change, especially in module.rst, changes.rst, the sticky/module-tags design docs and the sticky-modules cookbook.
Also good to check if this has an impact on other stuff mentioning sticky modules like stash-environment, initial-environment, conflict_unload, evaluation-errors. Check these design doc and adapt them if required.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purge skips sticky and super-sticky modules but still attempts to unload their non-sticky requirements. This reports an unrelated dependency error without explaining why the requirement remains loaded.
Preserve requirements needed by retained sticky modules and apply the sticky_purge reporting mode to their skipped unload.
Fixes #582
Assisted-by: Codex:gpt-5.6-sol