[epell-development]

Requested by epell · project thread

Closes #38

What changes

• Rule editor → What plays: when "the Adverts list" is chosen there are two options, "every advert" (what rules did before) and "only the adverts I tick". The second shows every advert in the list with a tick box (several can be ticked), its status (running today / not today / off / no audio file), and Tick all / Untick all. Switching to "only the adverts I tick" starts with all of them ticked. If nothing is ticked, the rule warns that it plays nothing. The rule summary says "from N chosen adverts".
• Adverts list: each advert has a new advertiser / company field, shown as "Advertiser — Name" in the rule picker, and a line saying which rules play it.
• Adverts get a stable id so rules keep the right adverts when the list is edited or reordered. Adverts saved by older versions get ids when the settings load (and in the Ads tool, for settings that come from an older server). Deleting an advert takes it out of the rules that chose it.
• Playout: rule_pool only takes the chosen adverts. "Taking turns" goes through them in Adverts list order.

Compatibility

Existing rules have ad_choose = false, so they keep playing every advert in the list. When connected to a server, the new fields travel with the ads / ad_rules settings the Ads permission already covers, so it works the same there. The web portal doesn't edit rules, so it has nothing to change.

Checks

cargo fmt, cargo clippy --all-targets -- -D warnings, cargo test (two new tests: chosen adverts / deletion, and ids for old adverts), tools/extract_strings.py, tools/check_glyphs.py. Checked in the running app under Xvfb. It merges cleanly with #36.

---

Generated by Claude Code

[mergeguards]

MergeGuard review
Risk: 🔴 60/100 — risky
Findings: 🔴 1 high
Open Files changed for 1 inline review thread on the diff.

💡 Use the Fix All MergeGuard Findings checkbox comment on this PR to apply auto-fixes in batch, or reply @mergeguards fix on any inline finding.

⚠️ This PR may benefit from a deep scan — consider triggering @mergeguards deep-scan.

---

Reviewed by MergeGuard AI

[mergeguards]

MergeGuard agent actions

Fix all findings

Fix-all did not complete.

Manual fixes needed (1)

MergeGuard could not commit these automatically. Expand each file for the suggested fix.

`src/adsui.rs` — Skipped committing — the fix removed closing brace(s) from the enclosing…

Skipped committing — the fix removed closing brace(s) from the enclosing function/block (lines 471-473).

Please apply this change manually — MergeGuard drafted a fix but could not commit it to this branch.

Suggested approach:
The checkbox handler now copies the advert id into a value and uses it consistently, preventing any reference/deref confusion and accidental duplicates. This keeps add/remove logic correct and safe when toggling tick boxes.

Model confidence: 78%.

You can try again with the checkbox:

• Fix All MergeGuard Findings

_{Or reply with @mergeguards fix-all.}

All issues (1)

• high · src/adsui.rs:470 — Potential logic error in checkbox state synchronization. When on is true, the code pushes *id to r.ad_ids, but id is already a reference from the iterator. This creates a double-dereference…