Handle short reads and truncated binary input - #57
Open
sylvesterkaczmarek wants to merge 1 commit into
Open
sylvesterkaczmarek wants to merge 1 commit into
sylvesterkaczmarek wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #56.
Keep filling the input buffer until the requested bytes are available. Reject exhausted streams, reads without progress and truncated array buffers with
MALExceptioninstead of decoding unfilled or stale bytes.Add 11 regressions covering fixed/variable decoding, fragmented strings and byte blocks, buffer compaction, split-binary bit-store preservation, truncation and I/O failures.
Validation:
mvn -B -ntp -f encodings/encoding-binary/pom.xml clean testpassed all 11 tests. Seven of the initial eight regression tests failed before the fix. The full reactor was not run.