Skip to content

ci: use new PR preview action - #223

Open
vojtechsimetka wants to merge 9 commits into
masterfrom
ci/use-new-preview-action
Open

ci: use new PR preview action#223
vojtechsimetka wants to merge 9 commits into
masterfrom
ci/use-new-preview-action

Conversation

@vojtechsimetka

Copy link
Copy Markdown
Contributor

No description provided.

@filoozom

filoozom commented Mar 7, 2022

Copy link
Copy Markdown

Should hopefully work by just re-running the job. I'm not allowed to do so. 🙂

Comment thread .github/workflows/check.yaml Outdated
@agazso

agazso commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

I get {"message":"path address not found","code":404}. It seems that the index-document is not set correctly.

@filoozom

filoozom commented Mar 8, 2022

Copy link
Copy Markdown

I get {"message":"path address not found","code":404}. It seems that the index-document is not set correctly.

Ah indeed, I'm not doing this:
https://github.com/ethersphere/swarm-cli/blob/4545f2b29c1a8468fb85a91d98463729682847ab/src/command/upload.ts#L144-L147

Wonder if this should be included in the actions that were meant to be as "basic" as possible. Should I force people to use specify index-document, or do this magic?

@agazso

agazso commented Mar 8, 2022

Copy link
Copy Markdown
Contributor

I get {"message":"path address not found","code":404}. It seems that the index-document is not set correctly.

Ah indeed, I'm not doing this: https://github.com/ethersphere/swarm-cli/blob/4545f2b29c1a8468fb85a91d98463729682847ab/src/command/upload.ts#L144-L147

Wonder if this should be included in the actions that were meant to be as "basic" as possible. Should I force people to use specify index-document, or do this magic?

Maybe I would not do this magic for all the actions, but the point of the PR preview is to upload a website for previewing it and websites are not working correctly without it. Forcing people to specify index-document all the time may work, but it's not a great user experience.

What I would do instead is that do this magic in the pr-preview action but make it overridable, so I would also expose the index-document as a variable with an option to set it to anything else or undefined in case someone wants to override the default "magic" behavior.

@vojtechsimetka
vojtechsimetka marked this pull request as ready for review March 12, 2022 14:01
@vojtechsimetka
vojtechsimetka requested a review from Cafe137 as a code owner March 12, 2022 14:01
@ethersphere ethersphere deleted a comment from bee-worker Mar 22, 2022
@vojtechsimetka
vojtechsimetka force-pushed the ci/use-new-preview-action branch from dd736e9 to 5fc0fbb Compare March 22, 2022 16:23
@bee-worker

bee-worker commented Mar 22, 2022

Copy link
Copy Markdown
Collaborator

🐝 PR preview in Swarm

Preview URL: https://bah5acgzafc2w5ztugkxjd3tyyw7iuzrxf7udits6ff6vogncuzj5j65xj5cq.bzz.link
Swarm Hash: 28b56ee67432ae91ee78c5be8a66372fe8344e5e297d5719a2a653d4fbb74f45
Commit Hash: 14d63f6
Commit Message: ci: should continue even if fails to upload to testnet

@vojtechsimetka
vojtechsimetka force-pushed the ci/use-new-preview-action branch from b7a898b to 14d63f6 Compare May 10, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants