Repository navigation
Add WHM findDnsZone for a single DNS cluster lookup - #4
Merged
Merged
Conversation
parse_dns_zone replaces deprecated dumpzone and avoids querying every web server. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Whm::findDnsZone()which calls WHM API 1parse_dns_zoneonce against the configured server.dumpzone. On a synchronized DNS cluster the DNS role already holds every member's zones, so callers do not need to query each web server.nullwhen the zone is absent. The token needs thelist-zonesprivilege.Test plan
vendor/bin/pest --compact tests/Feature/WhmTest.phpvendor/bin/phpstan analyse src/Whm.php src/Contracts/WhmInterface.phpfindDnsZone()against a DNS cluster member for a zone that exists only on another web server and confirm it is foundMade with Cursor