[reximus-bbs]

source_record_filter_destroy queued force_stop_output_task via
run_queued and then called source_record_delayed_destroy directly,
which could free the context before the queued tasks ran. On OBS exit
the queue often stops processing before those tasks fire, leaving
outputs in a stopping state that OBS waits on — causing the hang.

Introduces stop_output_sync() which force-stops and releases an
output inline, and uses it in the closing paths (filter_remove,
destroy, and the closing branches of filter_update). Non-closing
stops (toggle-off, tick restart/disable) keep the async path.
delayed_destroy is removed and its cleanup inlined into destroy.

[exeldro]

With these changes I get a crash when I try to close OBS, switch scene collection or remove the filter when replay buffer on source record is active. The source record was on the active scene.

[reximus-bbs]

Pushed a fix. stop_output_sync was unconditionally releasing outputs — during exit release_output_stopped skips the release and lets the output manager clean up. Added the same exiting check. Also added an encoder inactivity wait in destroy before releasing, matching what delayed_destroy did via re-queue.

Tested on OBS 32.1.1 with replay buffer active — close OBS, switch scene collection, remove filter. No crash, no hang. What OBS version are you building against?

[exeldro]

I test on OBS 32.1.1
The crash on exiting OBS is now replaced by a reference leak of the output.
Still a crash when I remove the source record filter or switch scene collection.

[exeldro]

The code seems to work now, I plan to do a code review in the next days

[reximus-bbs]

Thanks. The last commit (f689e67) is the one to review. Moved obs_output_release out of stop_output_sync into destroy, after the encoder inactivity poll. No more early release racing end_data_capture_thread, and outputs always get released on exit. There's also a test-harness branch with some simplified lifecycle tests (not end-to-end) if that's useful.

Thanks for the plugin btw, we use it all the time.