Repository navigation
Add WebSocket replay buffer paths and fix OBS exit crashes - #182
Merged
Merged
Conversation
Contributor
Author
|
Forgot about the windows build change made to also allow for standalone windows builds.
|
Owner
|
Thank you for the pull request. Some of the changes look interesting, but I am not interested in the build changes. Can you remove those from the pull request? |
Melvin-Molder
force-pushed
the
emit-replay-buffer-path
branch
from
July 5, 2026 00:06
10607a5 to
63bb59e
Compare
Melvin-Molder
force-pushed
the
emit-replay-buffer-path
branch
from
July 5, 2026 00:52
63bb59e to
ee24c4f
Compare
Contributor
Author
|
Think I got it all removed now, I accidentally committed both in one commit so had to redo the history. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This merge implements support for specifying replay buffer save paths via the WebSocket flow, and resolves some memory management and threading bugs discovered during testing.
While testing the WebSocket changes, closing OBS on Windows 11 triggered a
c0000005access violation. Debugging the teardown sequence revealed multiple reference counting and race conditions that have been corrected here.Changes
os_sleep_ms(10)loop insource_record_filter_destroythat could stall OBS/plugin shutdown over lingering references.obs_source_release(parent);call insource_record_replay_savedthat incorrectly decremented reference counts during replay saves.audio_input_callbackto use arelease_audioflag soobs_source_release(audio_source);is deferred safely across all early exit paths."saved"signal too early so async replay writes can still emit the saved event.calldata_initand ensured event emission still occurs even when path resolution fails.