Repository navigation
[eas-cli] Read .gitignore files inside dot-directories - #4537
Open
AndrewSouthpaw wants to merge 2 commits into
Open
AndrewSouthpaw wants to merge 2 commits into
AndrewSouthpaw wants to merge 2 commits into
Conversation
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Fixes #4536. eas-cli skips
.gitignorefiles inside dot-directories when it copies the project for the build archive, so files git ignores there get uploaded. For us that was a ~9 GB jest cache under.repo/.How
Passes
dot: trueto thefg('**/.gitignore')call inIgnore.initIgnoreAsync. Also adds.gitto the glob'signorelist so it doesn't walk.git/objectsnow that dot-directories are in play.Test Plan
.gitignoreinside a dot-directory. It fails without the fix.yarn test src/vcs,yarn typecheck, andyarn fmt:checkpassbig-fileis no longer copied.Ignoreagainst our monorepo. Files under.repo/jest-cacheare now ignored.