Repository navigation
[Feature] Send money in OpenBanking + payment tasks - #107
Open
aaronsmulktis wants to merge 14 commits into
Open
aaronsmulktis wants to merge 14 commits into
aaronsmulktis wants to merge 14 commits into
Conversation
…d money button, tidy the review
… sides, give it a memo that meets its rules
aaronsmulktis
marked this pull request as ready for review
October 30, 2026 22:29
marksibrahim
requested changes
Nov 2, 2026
marksibrahim
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Payment worked as expected with the contacts. A couple of issues to fix before merging:
- Amount with commas: src/open_apps/apps/openbanking_app/send.py:76. parse_amount removes every comma, not just thousands separators.
- "18,50" becomes 1850.00 and "1.850,00" becomes 1.85.
- Pending becomes available after payment is submitted. It should remain pending:
Contributor
There was a problem hiding this comment.
@aaronsmulktis do we need all these test screenshots commited in the repo?
| name, each with casual, formal and unrelated-context phrasings. Kept out of | ||
| `all_tasks`, like the OpenBanking set. | ||
| - Known sender names in the messenger link to their contact card. | ||
| - **Send money** in OpenBanking: a Send money link on every deposit account |
Contributor
There was a problem hiding this comment.
Sweet, thanks for keeping this up to date!
…ed transfer post dated, with balances
marksibrahim
approved these changes
Nov 3, 2026
marksibrahim
left a comment
Contributor
There was a problem hiding this comment.
looks good, thank you Aaron!
…the field to what will be sent
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
contacts_app.add_contact)as_of_datein the pack's date format, with the running balance after each row; a refused send writes nothingSendMoneyTask: exact payee match (samortiz@ is not sam.ortiz@),to_contactaccepts any of the contact's handles, memo rules match whole words with alternatives ("Unit-2" and "Apt Refactor test setup in test_apps.py #2" pass, "Unit 21" fails)BuyWithCardTask,DeclinedCardPurchaseTask) predict each row's date and balance viaposting_date(override for german/mandarin)tasks=payments: pay September's rent from the lease in Files (with decoys in the misleading Contacts and Files packs), send Bob $18 by name, pay Sam Ortiz and save them, each in casual/formal/unrelated-context phrasings; kept out ofall_tasksnote_pending_transfer_in_calendar_and_todo→note_realtime_transfer_in_calendar_and_todosend_paymentand the pages, reward pass/fail cases on live app state, the task set under the default and misleading Contacts packs, and a Playwright run through the whole flowtasks.md;CHANGELOGentry