Repository navigation
Add --use-device-time to shared comms args - #226
Draft
rootkiller6788 wants to merge 1 commit into
Draft
rootkiller6788 wants to merge 1 commit into
rootkiller6788 wants to merge 1 commit into
Conversation
--use-device-time was only registered by commsCollBench (comms.py), but commsParamsHolderBase unconditionally reads args.use_device_time. Benches that rely on the shared base readArgs (commsTraceReplay.py, dlrm.py) therefore crashed at startup with AttributeError: 'Namespace' object has no attribute 'use_device_time'. Move the flag into ParamCommsBenchBase.readArgs so every comms bench accepts it, and drop the now-duplicate registration in comms.py. Add regression tests for the replay bench args.
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
commsTraceReplay.py(anddlrm.py) crash at startup withbecause
commsParamsHolderBase.__init__readsargs.use_device_time, but the--use-device-timeflag was only registered bycommsCollBench.readArgsincomms.py. Benches built on the shared baseParamCommsBenchBase.readArgs(trace replay, DLRM) never got the argument.Fix
--use-device-time(defaultFalse) inParamCommsBenchBase.readArgsso every comms bench accepts it.commsCollBench.readArgsincomms.py.This also makes
--use-device-timeusable on the replay path, matchingcommsParamsHolderBase's existing handling.Verification
AttributeErroron currentmainvia the replay bench arg parser.commsParamsHolderBaseconstructs for trace-replay, DLRM, collective, compute and overlap benches, and--use-device-timeis accepted.train/comms/pt/tests/commsTraceReplay_tests.py; the fullcommsTraceReplay_tests+comms_utils_testssuite passes (38/38).Closes #213