fix(share,r): validate map_name/verbose on master - #71
Merged
davidbudzynski merged 3 commits intoSep 20, 2026
Merged
Conversation
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #71 +/- ##
==========================================
+ Coverage 98.01% 98.27% +0.26%
==========================================
Files 13 13
Lines 5083 5105 +22
==========================================
+ Hits 4982 5017 +35
+ Misses 101 88 -13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #59.
shareData/getDatapassed raw args to C:"",NA_character_and R-coerced numerics (viasub()inshmName) reachedshm_openand produced only the cryptic* Creating file mapping...ERROR(cf. #40).close(conn)had noon.exitguard, leaking the connection whenserializefails.R/call.R:shmNamenow validates (is.character+ length 1 +!is.na+nzchar, NA checked beforenzcharsincenzchar(NA)is TRUE) then normalizessub("^/*", "/", .); new internalcheckVerbose(is.logical+ length 1 +!is.na, message matches house style); also applied toclearData; connections closed viaon.exit(close(conn), add = TRUE)(explicit close removed to avoid double-close).test-share.R: 9 validation tests (share-0059.001–009) placed before the shm-gated roundtrip so they run even without shm.NEWS.md: bug-fix entry.Verification: all bad inputs now fail fast with clear R errors, valid roundtrip + clearData still TRUE, full tinytest suite green (1418 results). R-only, O(1) checks before O(n) serialize — no hot-path impact.