Skip to content

chore(desc): R floor 3.5.0, ByteCompile, Suggests metadata (#58) - #72

Merged
davidbudzynski merged 3 commits into
fastverse:masterfrom
davidbudzynski:chore/58-desc-metadata
Sep 20, 2026
Merged

davidbudzynski merged 3 commits into
fastverse:masterfrom
davidbudzynski:chore/58-desc-metadata

Conversation

@davidbudzynski

@davidbudzynski davidbudzynski commented Sep 20, 2026

Copy link
Copy Markdown
Collaborator

Closes #58 (metadata part).

Changes:

  • DESCRIPTION: Depends: R (>= 3.5.0) (was 3.1.0, matches src/kit.h:19-22 DATAPTR_RO fallback; ...length() in R/call.R, R_RegisterCCallable in src/init.c:39-66, STRING_PTR_RO need newer), ByteCompile: yes per WRE (was TRUE), drop Repository: CRAN from dev tree, add Config/Needs/website: pkgdown.
  • DESCRIPTION: add David Budzynski as ctb in Authors@R/Author (Maintainer stays Sebastian Krantz — R allows only one Maintainer).
  • Suggests unchanged (already data.table, knitr, rmarkdown, tibble, tinytest — verified via rg: data.table/tibble used in inst/tinytest/test-enc.R, tinytest in tests/tinytest.R, knitr/rmarkdown in vignette). No Config/testthat/edition (tinytest, not testthat) or RoxygenNote (hand-written Rd).
  • NEWS.md: note under development version Notes.

WRE refs (https://cran.r-project.org/doc/manuals/r-release/R-exts.html#The-DESCRIPTION-file):

  • ByteCompile is a logical field — canonical values yes/true/no/false (capitalized accepted). TRUE works, yes is the standard form, so normalized.
  • Repository: Built/Packaged must not be in source (added by tools), and 'Some repositories (including CRAN...) add their own fields.' Repository: CRAN is added by CRAN on publish, so removed from dev tree.

Why 3.5.0 not 4.x:

  • Keeps src/kit.h:29-31 isDataFrame shim for R<4.5. Bumping to >=4.5 to drop shim would break CI oldrel-4 (~4.2). Leave for later with matrix trim.
  • CI matrix oldrel-1..4 + release + devel all satisfy >=3.5, no workflow change.

Verification:

  • R CMD build: DESCRIPTION meta-information OK (including after author addition).
  • R CMD check --as-cran --no-manual --no-build-vignettes (R 4.6.1 macOS): DESCRIPTION OK, dependencies OK, tests OK, no metadata NOTEs. Remaining 3 WARNINGs + 1 NOTE are env-only (missing pandoc/checkbashisms, inst/doc absent due to --no-build-vignettes).
  • Investigation details posted to chore(desc): R version floor, ByteCompile, Suggests #58 as comment.

Branch from master @ 4d1d79d.

@codecov-commenter

codecov-commenter commented Sep 20, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.27%. Comparing base (99413b6) to head (0615a3b).
⚠️ Report is 71 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #72      +/-   ##
==========================================
+ Coverage   98.01%   98.27%   +0.26%     
==========================================
  Files          13       13              
  Lines        5083     5105      +22     
==========================================
+ Hits         4982     5017      +35     
+ Misses        101       88      -13     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@davidbudzynski
davidbudzynski merged commit d2d73ec into fastverse:master Sep 20, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(desc): R version floor, ByteCompile, Suggests

2 participants