Fix RareLabelEncoder for an existing replacement category - #1096
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
Open
AHMETHAKANBEZIR1 wants to merge 1 commit into
AHMETHAKANBEZIR1 wants to merge 1 commit into
Conversation
Co-authored-by: Codex <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1095.
Problem and change
RareLabelEncoder.transform unconditionally calls pandas Categorical.add_categories(replace_with), even when that label is already present. It raises for observed or unused existing replacement categories and when transforming its own categorical output again.
Add the category only when absent. Existing category order and ordered flag are preserved; new labels still follow the original add_categories path. Document that replace_with can already be a category.
Validation
The merged #1030 targets narwhals-migration, not main; its pandas categorical path still calls add_categories unconditionally. It was inspected for overlap. This PR is a focused fix on the documented main contribution target; no migration runtime or Polars validation is claimed. Whole-package mypy was not rerun; the focused changed module check passed.
AI disclosure
OpenAI Codex autonomously investigated, reproduced, implemented and validated this contribution at AHMETHAKANBEZIR1's request. No independent human code review is claimed. The commit includes Codex co-authorship.