Skip to content

PF-2710 Upload test artifacts in ci-pr-checks-image.yml - #520

Open
larsbard wants to merge 4 commits into
mainfrom
PF-2710
Open

larsbard wants to merge 4 commits into
mainfrom
PF-2710

Conversation

@larsbard

@larsbard larsbard commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Description

Type of Change

  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • ✨ New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing caller
    workflows to fail)
  • ♻️ Refactor (code improvement without functional change)
  • 📝 Documentation update

Checklist for Shared Workflows & Actions

  • Documentation: I have added or updated the relevant documentation
    (e.g., usage docs, README.md, or inline workflow or action descriptions) to
    reflect these changes.
  • Input Propagation: If I added new inputs , I have exposed them in
    all relevant proxy workflows or caller templates that rely on this workflow or
    action.
  • Cross-Workflow Relevance: I have checked if this change (or bug fix)
    applies to other shared workflows/actions in this repository and updated them
    if necessary.
  • Testing: I have tested these changes against a caller repository.

Testing Details

Additional Context

@larsbard
larsbard requested a review from a team as a code owner October 27, 2026 11:14
@larsbard
larsbard requested a balanced review from Copilot October 27, 2026 11:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Namespaced image names produce invalid artifact names, preventing report uploads for affected callers.

1 open issue
What changed in this PR

This PR adds optional test-report uploads to the shared Spring Boot image checks, helping callers diagnose failed Maven builds.

Changes:

  • Adds and forwards the test-report-path input.
  • Uploads matching reports after failure, ignoring missing files.
  • Documents configuration, path handling, and multi-module examples.
File Description
docs/​pull-request-image.md Documents report uploads and path configuration.
.github/​workflows/​ci-spring-boot-container-scan.yml Adds the report-path input and artifact upload step.
.github/​workflows/​ci-pr-checks-image.yml Exposes and forwards the report-path input.

Review effort: Balanced

Comment thread .github/workflows/ci-spring-boot-container-scan.yml Outdated
@larsbard

Copy link
Copy Markdown
Contributor Author

Har ikke sjekket boks 2+3, da jeg er usikker på om cucmber-tester blir brukt i quarkus/docker-images. Tanker @emilarnesen ?

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The temporary workflow branch reference and missing default artifact-name fallback need correction before merging.

2 open issues
1 resolved since last review

Review effort: Balanced

inputs.enable-container-image-scan == true &&
inputs.application-type == 'spring-boot'
uses: felleslosninger/github-workflows/.github/workflows/ci-spring-boot-container-scan.yml@main
uses: felleslosninger/github-workflows/.github/workflows/ci-spring-boot-container-scan.yml@PF-2710
Comment thread .github/workflows/ci-spring-boot-container-scan.yml Outdated
larsbard and others added 2 commits October 27, 2026 12:31
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The shared Spring Boot workflow still references the temporary PF-2710 branch rather than main, risking caller failures when that branch is deleted.

1 open issue
1 resolved since last review

Review effort: Balanced

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants