Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Namespaced image names produce invalid artifact names, preventing report uploads for affected callers.
1 open issue
What changed in this PR
This PR adds optional test-report uploads to the shared Spring Boot image checks, helping callers diagnose failed Maven builds.
Changes:
- Adds and forwards the
test-report-pathinput. - Uploads matching reports after failure, ignoring missing files.
- Documents configuration, path handling, and multi-module examples.
| File | Description |
|---|---|
docs/pull-request-image.md |
Documents report uploads and path configuration. |
.github/workflows/ci-spring-boot-container-scan.yml |
Adds the report-path input and artifact upload step. |
.github/workflows/ci-pr-checks-image.yml |
Exposes and forwards the report-path input. |
Review effort: Balanced
Contributor
Author
|
Har ikke sjekket boks 2+3, da jeg er usikker på om cucmber-tester blir brukt i quarkus/docker-images. Tanker @emilarnesen ? |
| inputs.enable-container-image-scan == true && | ||
| inputs.application-type == 'spring-boot' | ||
| uses: felleslosninger/github-workflows/.github/workflows/ci-spring-boot-container-scan.yml@main | ||
| uses: felleslosninger/github-workflows/.github/workflows/ci-spring-boot-container-scan.yml@PF-2710 |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Description
Type of Change
workflows to fail)
Checklist for Shared Workflows & Actions
(e.g., usage docs,
README.md, or inline workflow or action descriptions) toreflect these changes.
inputs, I have exposed them inall relevant proxy workflows or caller templates that rely on this workflow or
action.
applies to other shared workflows/actions in this repository and updated them
if necessary.
Testing Details
Additional Context