Repository navigation
chore(oauth): remove the OAUTH_ALLOW_UNBOUND_STATE escape hatch - #483
Merged
Merged
Conversation
# Conflicts: # docs/configuration.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #476.
0.19.2 bound the OAuth state to the client that started sign-in (#463) and kept
OAUTH_ALLOW_UNBOUND_STATEfor clients to catch up, with removal promised for v0.20. A callback without a binding is now always refused; setting the variable only produces a boot warning that it is ignored.Deployments we run do not set it (checked: portal auth, RoxTarget, Grand Cross, tenant stacks in seamless-terraform-service). RoxTarget web and mobile already send the binding.
Checks: typecheck, lint, prettier, build, coverage (141 files, 1975 tests, thresholds met).