Repository navigation
feat(oauth): add the state binding to the start response and callback request - #104
Merged
Merged
Conversation
This was referenced Oct 21, 2026
fix(oauth): bind the OAuth state to the client that started sign-in
fells-code/seamless-auth-api#465
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
bindingtoStartOAuthLoginResponseSchemaandFinishOAuthLoginRequestSchema, for fells-code/seamless-auth-api#463.The auth server will return a random
bindingfrom/oauth/:providerId/start, put its hash in the signed state, and require it on/oauth/:providerId/callback, so astatecan only be finished by the client that started the sign-in (login CSRF, RFC 9700 section 4.7).Both fields are optional in the schemas so a client can still parse a response from an older auth server. The auth server enforces presence itself.
Contract change. Release order: this package, then the API (#463), then
@seamless-auth/client/react/react-native.Checks: typecheck, lint, format:check clean; vitest 290 passed; build ok.