Repository navigation
test(verify): send the OAuth state binding with harness callbacks - #298
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs fells-code/seamless-auth-api#463
The auth API (fells-code/seamless-auth-api#465) now returns a
bindingfromPOST /oauth/:providerId/startand requires it in thePOST /oauth/:providerId/callbackbody. The verify harness posts OAuth callbacks by hand, sooauthLogin(flows.ts) andlegacySignIn(cutoverFlows.ts) now forward the binding from the start response.Safe to merge before the API releases: older API images strip the unknown field, and the harness does not assert that
bindingis present (an absent value is dropped from the JSON body). The mock OIDC server only echoesstateand needs no change. Patch changeset included since the harness ships withseamless verify.