Add missing BigUint64 runtime aliases - #377
Open
saitakarcesme wants to merge 1 commit into
Open
saitakarcesme wants to merge 1 commit into
saitakarcesme wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #318 and #353.
Expose
readBigUint64LE,readBigUint64BE,writeBigUint64LEandwriteBigUint64BEas aliases of the existingBigUInt64methods, matching Node's capitalization aliases. Use the same function objects, including the existingBigInt not supportedfallback.Regression tests verify alias identity, zero/ordinary/maximum unsigned values, default and nonzero offsets, write return offsets, unchanged prefix bytes, and range errors. Eight existence/identity assertions fail on the original source; all 46 assertions pass after the fix.
Validation with Node 24.21.0:
npm test: 1,048,608 assertions passed.npm run standard -- index.js test/bigint-aliases.js: passed.BigIntunavailable confirms all four aliases retain the same fallback function/error.git diff --check: passed.This PR supplies the missing runtime methods. The corresponding TypeScript declarations are already proposed in open PR #360, so this does not duplicate that contributor's declaration changes. Browser-specific runners were not run locally.
AI disclosure: implemented and tested by OpenAI Codex at the account owner's request. No claim of independent human code review.