Fix heredoc and Internals core-test compatibility - #1365
Merged
Conversation
Handle indented delimiters, eval substitution bodies, EOF termination, and Perl-compatible heredoc diagnostics on both backends. Generated with Codex (https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
Validate Internals native arguments that bypass Perl prototypes and report their Usage diagnostics at the Perl call site. Generated with Codex (https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
fglock
force-pushed
the
fix/heredoc-core-test
branch
from
September 13, 2026 11:33
2f79914 to
f786f96
Compare
Keep collected heredoc source intact for nested parsing and source locations, and retain SvREFCNT aggregate calls while validating prototype bypasses. Generated with Codex (https://openai.com/codex) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Internals::*usage diagnostics when calls bypass their Perl prototypesInternalsargument-validation pathValidation
makeprove src/test/resources/unit/heredoc.tprove src/test/resources/unit/internals_prototype_bypass.tperl5_t/t/op/heredoc.ton JVM and interpreter backendsperl5_t/t/lib/universal.ton JVM and interpreter backendsmake check-linksGenerated with Codex (https://openai.com/codex)