fix: restore tied FETCH and substitution pos state - #1366
Merged
Conversation
Normalize tied scalar operands at runtime operation boundaries and preserve single FETCH evaluation through sort comparator references. Add a focused tied scalar sort regression test. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
Keep match-position cache state attached to the original scalar so global substitutions using pos() and \G do not abort. Add focused global substitution position regression coverage. Generated with [Codex](https://openai.com/codex/) Co-Authored-By: Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pos()cache identity during global substitution sore/subst*.tno longer aborts at test 188pos()/\GValidation
makeprove src/test/resources/unit/tied_scalar_sort_fetch_once.tprove src/test/resources/unit/regex/substitution_global_pos_state.tperl dev/tools/perl_test_runner.pl --jobs 3 --timeout 300 perl5_t/t/re/subst.t perl5_t/t/re/substT.t perl5_t/t/re/subst_wamp.tThe UAT trio now completes at 275/281 each; the reported 185/281 incomplete regression is resolved.