Conversation
…imal-comma area (#223)
m-mohr
requested review from
ivorbosloper and
saidy-moregeo
and
a balanced review from Copilot
September 8, 2026 07:47
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The 2023-specific aliases and archive handling lack dedicated regression coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Backfills DE-SH conversion for 2023–2025 with edition-specific formats.
Changes:
- Normalizes edition-specific columns and archive contents.
- Parses German dates and decimal-comma areas.
- Adds required-output-column checks.
File summaries
| File | Description |
|---|---|
tests/test_convert.py |
Adds required DE-SH output-field assertions. |
fiboa_cli/datasets/de_sh.py |
Implements edition-specific conversion and parsing fixes. |
CHANGELOG.md |
Documents the converter fixes. |
Review details
- Files reviewed: 3/4 changed files
- Comments generated: 2
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+53
to
+56
| # 2023; flgesamt (gross) equals flnetto (net) in all 198,614 rows | ||
| "flident": "FLIK", | ||
| "flgesamt": "Flaeche", | ||
| "hbn": "HBN", |
Comment on lines
+110
to
+112
| expected_columns = { | ||
| "de_sh": ("determination:datetime", "metrics:area", "flik", "hbn", "id"), | ||
| } |
saidy-moregeo
approved these changes
Sep 8, 2026
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This one is cherry-picked from #223 and merges into main instead.