Repository navigation
Complete KnowledgeDigest full-care and packaging - #3
Merged
Merged
Conversation
Signed-off-by: Lukas Geiger <lukas@um-bruch.org>
|
Welcome! 👋 Thanks for your first pull request in this repository. A maintainer will review it soon. Please make sure:
Thanks for contributing! |
lukisch
commented
Oct 12, 2026
lukisch
left a comment
Collaborator
Author
There was a problem hiding this comment.
Root review of f3750f8: documentation reconciled with provider/configuration/runtime source; wheel/sdist icon and source-document link targets verified with byte parity. Local clean-source suite 213 passed, 5 optional Transit skips; four required Python CI jobs, package artifact job and CodeQL pass. The non-required welcome action twice failed on GitHub API HTTP 502; no workflow-source fault identified. This external lifecycle failure is retained for follow-up and is not represented as green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Separates the documented local SQLite/FTS workflow from optional provider and synchronization data flows, and narrows security and licensing claims to what the current implementation and reviewed dependency files support. Packaging includes the Qt icon in the wheel and sdist; the sdist carries its linked documentation and explicit manifest. Installed-artifact smoke checks cover both artifacts. Version 0.4.0 is unchanged.
Local verification: 218 tests collected, 213 passed, and 5 optional SQLite Transit tests skipped because that dependency was not installed. All six GUI tests ran. Ruff and diff checks passed; wheel and sdist builds, CLI help, and installed icon smoke checks passed. GitHub CI remains the required merge gate.
Artifacts:
knowledgedigest-0.4.0-py3-none-any.whl— SHA-256f4fbdc147a9c77bd8871e0c892340d26b7b8d8eaa60377f6661c967c7bf7ccf5knowledgedigest-0.4.0.tar.gz— SHA-256f6325bc0cd85ff2a22e84bead8c73a457968fb1050f5143e27ded87691aee347