[WIP] feat: Add AggregateField and Sum with Query - #1705
Conversation
|
One thing to fix before this goes further — AggregateQuery QueryInternal::Aggregate(const AggregateField& aggregate_field) {
// TODO: Implement Aggregate
// return MakePublic(aggregate_field);
}That falls off the end of a non-void function, which is UB — with optimization The good news is that the desktop implementation is small. The vendored core So Two details that cost me time: a sum of integers comes back as I have this working on desktop against the Firestore emulator as a downstream |
#1703
Description
Testing
Type of Change
Place an
xthe applicable box:Notes
Release Notessection ofrelease_build_files/readme.md.