Repository navigation
fix(https): stop logging the request body when callable data is missing - #1991
Draft
IzaakGough wants to merge 1 commit into
Draft
IzaakGough wants to merge 1 commit into
IzaakGough wants to merge 1 commit into
Conversation
The check runs before auth, so the caller's body was written to the logs.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request ensures that the request body is not logged when it is missing the required data field, preventing potential leakage of sensitive information before authentication is verified. A corresponding unit test has been added to verify this behavior and ensure that secrets in the body are not logged. I have no additional feedback to provide as the changes are correct and well-tested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a callable or task queue function got a request without
data, the warning log included the whole request body, before any auth check.This logs the warning without the body.
Tested with a new unit test and by calling the validator directly. Not tested on a deployed function.
relnote: Callable and task queue functions no longer log the request body when it is missing
data.