Skip to content

Correct skill installation and monitoring cost - #215

Merged
Max17190 merged 1 commit into
mainfrom
docs/fix-install-and-monitor-cost
Sep 2, 2026
Merged

Correct skill installation and monitoring cost#215
Max17190 merged 1 commit into
mainfrom
docs/fix-install-and-monitor-cost

Conversation

@Max17190

@Max17190 Max17190 commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Why

The bundled install guidance says init installs build skills, but build skills require a separate setup step. The monitor skill also omits the published cost model for recurring checks.

Summary

  • State that init installs the CLI, core skills, and workflow skills.
  • Document firecrawl setup build as the separate build-skill step.
  • Add one sentence linking monitoring checks to their underlying operation and optional judging costs.

Test Plan

  • pnpm test, 433 passing tests
  • pnpm run type-check
  • pnpm run format:check
  • pnpm run build
  • git diff --check

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 3 files

Re-trigger cubic

@Max17190
Max17190 force-pushed the docs/fix-install-and-monitor-cost branch from 1c135e4 to 5f1f016 Compare September 2, 2026 16:36
@Max17190 Max17190 changed the title Correct install skill-family copy and document monitor credit cost Add docs-search CLI parity and correct agent skill guidance Sep 2, 2026

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 12 files (changes from recent commits).

Prompt for AI agents (unresolved issues)

Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.


<file name="src/commands/docs-search.ts">

<violation number="1" location="src/commands/docs-search.ts:73">
P2: When the custom API URL comes from configuration rather than this command’s `--api-url`, this expression sends the stored API key to that custom endpoint. Check the effective normalized `apiUrl` instead, while retaining an explicitly supplied `options.apiKey` for authenticated self-hosted requests.</violation>
</file>

Reply with feedback, questions, or to request a fix.

Fix all with cubic | Re-trigger cubic

Comment thread src/commands/docs-search.ts Outdated
explicitApiUrl || normalizeApiUrl(config.apiUrl || DEFAULT_API_URL);
const apiKey =
options.apiKey ||
(explicitApiUrl && explicitApiUrl !== DEFAULT_API_URL

@cubic-dev-ai cubic-dev-ai Bot Sep 2, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: When the custom API URL comes from configuration rather than this command’s --api-url, this expression sends the stored API key to that custom endpoint. Check the effective normalized apiUrl instead, while retaining an explicitly supplied options.apiKey for authenticated self-hosted requests.

Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. At src/commands/docs-search.ts, line 73:

<comment>When the custom API URL comes from configuration rather than this command’s `--api-url`, this expression sends the stored API key to that custom endpoint. Check the effective normalized `apiUrl` instead, while retaining an explicitly supplied `options.apiKey` for authenticated self-hosted requests.</comment>

<file context>
@@ -0,0 +1,157 @@
+    explicitApiUrl || normalizeApiUrl(config.apiUrl || DEFAULT_API_URL);
+  const apiKey =
+    options.apiKey ||
+    (explicitApiUrl && explicitApiUrl !== DEFAULT_API_URL
+      ? undefined
+      : config.apiKey);
</file context>
Fix with cubic

Comment thread src/__tests__/commands/docs-search.test.ts Outdated
@Max17190
Max17190 force-pushed the docs/fix-install-and-monitor-cost branch from 5f1f016 to edecc80 Compare September 2, 2026 16:52
@Max17190 Max17190 changed the title Add docs-search CLI parity and correct agent skill guidance Add docs-search CLI parity and correct install guidance Sep 2, 2026
@Max17190
Max17190 force-pushed the docs/fix-install-and-monitor-cost branch from edecc80 to 819fa9a Compare September 2, 2026 17:08
@Max17190 Max17190 changed the title Add docs-search CLI parity and correct install guidance Correct skill installation and monitoring cost Sep 2, 2026

@hmishra2250 hmishra2250 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved — the install scope and monitoring-pricing wording now match the implemented behavior and published docs.

Nit (non-blocking follow-up): now that build skills are separate from init, surface firecrawl setup build in the post-init next-steps copy and, ideally, the interactive bare firecrawl setup picker so the command is not easy to miss.

@Max17190
Max17190 merged commit 06e2fd5 into main Sep 2, 2026
8 checks passed
@Max17190
Max17190 deleted the docs/fix-install-and-monitor-cost branch September 2, 2026 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants