fix: bound developer passage rendering - #216
Conversation
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Requires human review: Auto-approval blocked because this review re-detected 1 unresolved issue already reported by Cubic.
Re-trigger cubic
Require a closing fence to use the opening fence container. This keeps quoted list markers inside fenced code from ending the block.
|
@cubic-dev-ai review Please re-review exact head |
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
|
@cubic-dev-ai review Please review exact head |
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
a31e6ad to
dd5015f
Compare
|
@cubic-dev-ai review Please re-review exact head |
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
dd5015f to
1f1c149
Compare
|
@cubic-dev-ai review Please re-review exact head |
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
Fix all with cubic | Re-trigger cubic
1f1c149 to
82297f9
Compare
|
@cubic-dev-ai review Please re-review exact head |
@PhantomInTheWire I have started the AI code review. It will take a few minutes to complete. |
|
Closing: passage normalization (blank-line collapse, trailing-space trim, line cap with fence-aware truncation) belongs server-side so every consumer gets it and there is one set of rules. Server PR follows in firecrawl/search. No CLI-side fallback: the server rolls faster than users upgrade the CLI. |
Summary
firecrawl developerpassages--jsonand--prettyoutput completeMerge order
Merge this after firecrawl/search#1007, which performs the required server-side cleanup for existing indexed passages.
Regression coverage
Measurement
Exact-head (
82297f9694673f0e3f93553aa597aa4dd5be9f4b) offline replay of frozen server responses for 100 deterministic Flint GT queries, every fifth row from the 500-row corpus. Both renderers receive the same 1,502 passages.304 passages hit the line cap. The fence-aware cap introduced no additional unbalanced fences. Artifacts:
/Users/karan/.search-ops-scratchpad/passage-noise/cli-eval.Gates
pnpmis unavailable on this host, so the lockfile-installed binaries ran directly. The pre-commit hook failed only because it invokes missingpnpm; the equivalent checks above passed.