Release v0.2.15 - #44
Open
roncodes wants to merge 3 commits into
Open
Conversation
The api-keys console assigns the expiration dropdown's relative strings
('never', 'immediately', 'in 1 hour', ...) directly to expires_at, but the
attribute was declared @attr('date') and Ember Data's date transform
serializes any non-Date value to null — so every option reached the API as
expires_at: null and no expiry was ever persisted. The roll path was
unaffected because it reads the raw attribute and PATCHes it outside the
serializer.
Add an `expiration` transform that passes strings through for the server
to resolve (core-api's ApiCredential::setExpiresAtAttribute owns the
relative-time parsing), serializes real Dates to ISO strings, and
deserializes datetimes like the date transform so the display path
(expiresAt computed, list column) keeps receiving Date instances.
Also make the engine's own test suite runnable, since nothing covered this
path (or ran at all):
- eager-load the engine for its own `ember test` runs (fleetops pattern)
so the dummy app can resolve engine modules
- add @ember/legacy-built-in-components so ember-engines' LinkToExternal
has an extensible base class under ember-source 5.4
- add prismjs and skip the ember-prism component config for self-test
builds, where ember-cli-node-assets registers imports without funneling
the files and the vendor concat fails
- regression tests: relative strings survive model.serialize(), Dates
serialize to ISO, datetimes deserialize to Dates for display
…ation fix: API key expiration dropdown never persists — date transform nulls relative expiration strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release branch for v0.2.15. Merging this PR tags and publishes the release (release.yml reads the version from the branch name and validates package.json + RELEASE.md agree).
Contents
0.2.14→0.2.15and release notes (RELEASE.md)Checklist
package.jsonversion is0.2.15Related: fleetbase/core-api#246 — needed alongside this release for the
immediatelyoption to revoke at the exact boundary instant.