[kawacukennedy]

What?

Add 30-second connection timeouts to both SMTP dial paths (implicit TLS on port 465 and plain TCP for other ports).

Why?

Both tls.Dial and smtp.Dial blocked indefinitely if the remote server was slow to respond, a firewall silently dropped packets, or DNS resolution stalled. This hung the entire application with no way to cancel.

Also fixed IPv6 address formatting (fmt.Sprintf → net.JoinHostPort).

[floatpanebot]

This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size.

[floatpanebot]

Hi @kawacukennedy! Please fix the following issues with your PR:

• Title: Is too long (49 characters). The PR title must be strictly under 40 characters.
• Body: Missing the ## What? or ## Why? headings required by the PR template.

[floatpanebot]

Benchmark report — no significant change

Metrics worse: 0 · better: 0 (threshold: ±3%).

benchstat output

goos: linux
goarch: amd64
pkg: github.com/floatpane/matcha/backend
cpu: AMD EPYC 7763 64-Core Processor                
                           │    old.txt    │               new.txt               │
                           │    sec/op     │    sec/op      vs base              │
ParseSearchQuery_Simple-4    2.859µ ± 327%   2.987µ ± 153%       ~ (p=0.509 n=6)
ParseSearchQuery_Complex-4   8.777µ ±  74%   8.460µ ±  40%       ~ (p=0.589 n=6)
TokenizeSearchQuery-4        4.956µ ±  28%   3.989µ ±  61%       ~ (p=0.310 n=6)
geomean                      4.991µ          4.654µ         -6.76%

                           │  old.txt   │              new.txt               │
                           │    B/op    │    B/op     vs base                │
ParseSearchQuery_Simple-4    26.00 ± 0%   26.00 ± 0%       ~ (p=1.000 n=6) ¹
ParseSearchQuery_Complex-4   762.0 ± 0%   762.0 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        176.0 ± 0%   176.0 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      151.6        151.6       +0.00%
¹ all samples are equal

                           │  old.txt   │              new.txt               │
                           │ allocs/op  │ allocs/op   vs base                │
ParseSearchQuery_Simple-4    2.000 ± 0%   2.000 ± 0%       ~ (p=1.000 n=6) ¹
ParseSearchQuery_Complex-4   23.00 ± 0%   23.00 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        9.000 ± 0%   9.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      7.453        7.453       +0.00%
¹ all samples are equal

pkg: github.com/floatpane/matcha/tui
                    │   old.txt    │               new.txt               │
                    │    sec/op    │    sec/op     vs base               │
LogPanelView-4        154.4µ ± 21%   175.7µ ± 13%        ~ (p=0.065 n=6)
SearchOverlayView-4   173.4µ ± 12%   196.8µ ± 14%  +13.53% (p=0.041 n=6)
InboxConstruction-4   1.060m ± 38%   1.005m ± 13%        ~ (p=0.394 n=6)
geomean               304.9µ         326.3µ         +7.01%

                    │    old.txt     │               new.txt                │
                    │      B/op      │     B/op       vs base               │
LogPanelView-4        21.79Ki ± 105%   44.67Ki ± 51%        ~ (p=0.177 n=6)
SearchOverlayView-4   56.15Ki ±  41%   56.15Ki ± 41%        ~ (p=0.887 n=6)
InboxConstruction-4   874.5Ki ±   0%   874.5Ki ±  0%        ~ (p=0.853 n=6)
geomean               102.3Ki          129.9Ki        +27.04%

                    │   old.txt   │              new.txt              │
                    │  allocs/op  │  allocs/op   vs base              │
LogPanelView-4         712.0 ± 0%    714.0 ± 0%       ~ (p=0.242 n=6)
SearchOverlayView-4    926.0 ± 0%    926.0 ± 0%       ~ (p=0.727 n=6)
InboxConstruction-4   3.483k ± 0%   3.483k ± 0%       ~ (p=0.775 n=6)
geomean               1.319k        1.321k       +0.09%

_{auto-generated by benchmarks.yml}

Formatting issues have been resolved. Thank you!

[floatpanebot]

This has had no activity for 45 days. It will be closed in 21 days unless updated. Comment or remove the stale label to keep it open.

[kawacukennedy]

Hi @andrinoff — this PR is still open and all CI checks are green; just keeping it off the stale queue. Happy to rebase/adjust if anything needs updating. Thanks!

[floatpanebot]

This has had no activity for 45 days. It will be closed in 21 days unless updated. Comment or remove the stale label to keep it open.

[kawacukennedy]

Rebased onto the new v1.0.0 master to clear the conflict. The dial logic had moved into the new deliverSMTP helper, so I re-applied the fix there and also covered the identical un-timeouted dial in SendCalendarReply:

• Port 465 uses tls.Dialer with a net.Dialer timeout.
• Other ports use net.Dialer + smtp.NewClient instead of the timeout-less smtp.Dial.
• Both guarded by the new httpclient.SMTPDialTimeout (30s), and addr is built with net.JoinHostPort for correct IPv6 handling.

go build ./..., go vet, make test and golangci-lint are green locally, and the PR is now MERGEABLE.

[kawacukennedy]

CI note: the only failing check here is govulncheck, and it's a pre-existing issue on master (not caused by this PR). A new Go stdlib advisory, GO-2026-6809, was published after go 1.26.9 and is fixed in go 1.26.10; the repo still pins 1.26.9.

I've opened #1749 to bump the toolchain (also reachable via fetch → pkcs7 → x509). Once that lands, this PR's govulncheck will go green. Everything else in the matrix is passing.