Repository navigation
feat(tui): add unread-only filter - #1743
Open
christos-chatzifountas-biotz-io wants to merge 11 commits into
Open
christos-chatzifountas-biotz-io wants to merge 11 commits into
christos-chatzifountas-biotz-io wants to merge 11 commits into
Conversation
christos-chatzifountas-biotz-io
requested a review
from a team
as a code owner
October 17, 2026 08:37
Member
Benchmark report — no significant changeMetrics worse: 0 · better: 0 (threshold: ±3%). benchstat outputauto-generated by benchmarks.yml |
Member
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Member
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
Member
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Uand a command-palette action to toggle an unread-only view in the inbox and folders. The filter follows the active account tab and can be remapped withinbox.toggle_unread_only.pagination_page_sizeto config. It accepts a numeric cap such as40,"height", or a fraction such as"0.5*height". The default is40. The same size controls the first folder fetch and later pages, and the visible pager uses the available inbox pane rows up to the configured cap.Why?
Scrolling past read messages to find unread mail is slow, and filtering only the initially loaded page could hide unread messages later in a folder. The inbox pager previously used half the pane height regardless of the fetch size, and the first folder fetch requested every message. The page size setting now controls the visible and fetched page size. Folder unread counts could wrap to another row while mouse clicks still assumed one row per folder, causing the selected folder to drift farther above the cursor down the sidebar.
Fixes #1530.
Verification
make lintgo test ./config ./tui ./app ./internal/fetchcmd -timeout 90sgo test ./... -skip '^(TestConn_SendEvent|TestFetchEmails|TestFetchEmailsWithCustomServer)$' -timeout 90sThe three skipped existing tests require a live mail setup or hang in this environment; they are unchanged by this PR.
AI-assisted implementation, reviewed and tested locally.