Repository navigation
Conversation
The row is now sized from the list width before anything is drawn, and a zero or negative width draws nothing. The cursor and visual markers are chosen first and counted with the style frame, prefix, icon, and separator. Sender and subject are shortened with an ellipsis by display width, the date is kept only when two extra columns remain, and the styled line is clamped to the list width. Tabs and line breaks are shown as spaces, the stored title is left unchanged, and row chrome, status icon, and subject text live in small helpers. Fixes floatpane#1533
floatpanebot
previously requested changes
Oct 22, 2026
floatpanebot
left a comment
floatpanebot
left a comment
Member
There was a problem hiding this comment.
Hi @mvanhorn! Please fix the following issues with your PR:
- Title: Is too long (42 characters). The PR title must be strictly under 40 characters.
floatpanebot
added
bug
Member
Benchmark report — no significant changeMetrics worse: 0 · better: 0 (threshold: ±3%). benchstat outputauto-generated by benchmarks.yml |
mvanhorn
changed the title
floatpanebot
dismissed
their stale review
October 22, 2026 15:28
Formatting issues have been resolved. Thank you!
floatpanebot
added
bug
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
The inbox row is now sized from the list width before anything is drawn, and a zero or negative width draws nothing.
go test ./tui/...passed. The tests intui/inbox_test.gofail without the fix (checked by reverting the source changes).Fixes #1533
Why?
Long inbox subjects run past the row, so the date no longer sits on the right edge and rows of different lengths stop lining up. On a narrow width the date and the selection marker are carried out with the text, and a tab or line break in the subject or sender splits the row.
The painter kept a floor under every budget: the left side stayed at least 10 columns, the subject at least 4, and the padding at least 1. A narrow list therefore still received a string wider than the row.
The visual-selection marker was prepended after that string was measured, the date was always appended, and the list width was reduced by a hardcoded 2 columns. Truncation cut raw runes, and tabs and newlines in the sender and subject were copied onto the row.
AI was used for assistance.