fix: add missing metadata.last_modified to dart-write-documentation skill - #232
Closed
jwren wants to merge 1 commit into
Closed
fix: add missing metadata.last_modified to dart-write-documentation skill#232jwren wants to merge 1 commit into
jwren wants to merge 1 commit into
Conversation
…kill Add required `metadata` block with `last_modified` to dart-write-documentation. When this skill was synced from dart-lang/skills in flutter#224, it lacked this field, causing `LastModifiedRule` and `test/lint_skills_test.dart` to fail CI on PRs touching skills/.
|
The files within Please close this Pull Request and submit your changes to the upstream repository instead. Once merged upstream, your updates will be automatically brought over here. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the SKILL.md file for the dart-write-documentation skill by adding metadata, specifically specifying the model as models/gemini-3.1-pro-preview and updating the last_modified timestamp. There are no review comments, and I have no feedback to provide.
Member
Author
|
Closing in favor of upstream fix in dart-lang/skills as required by block-dart-skills-prs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
dart-write-documentationwas synced fromdart-lang/skillsin #224, it lacked themetadatablock withlast_modifiedrequired byLastModifiedRuleintool/generator/test/custom_skill_rules/last_modified_rule.dart.This caused
test/lint_skills_test.dartto fail CI across all platforms on PRs modifyingskills/(such as #230).Adding the missing
metadata.last_modifiedfield fixes CI.