Repository navigation
Prevent Windows tests from creating live ftown loops - #110
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Windows, tests changed HOME while Node homedir() reads USERPROFILE. Loop-store tests wrote enabled fixture loops into the real ~/.ftown/loops.json, causing repeated agent launches every minute.
Use USERPROFILE for Windows test isolation and retain HOME on Unix. Remove ExecutionPolicy Bypass and EncodedCommand from the direct shell launch. Skip the Unix file-mode assertion on Windows. Bump ftown-bridge to 0.19.33.
Validation: bridge build passed; 151 focused tests passed, one Unix-only test skipped. Real Windows PTY tests cover quoted arguments, native error exits and missing commands. Production loops.json stayed byte-for-byte unchanged during testing.
Existing polluted state requires separate recovery: fixture loops were backed up and disabled locally. This release prevents new pollution; it does not delete user loops.